LEGO: Pull request from juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260809103222429 to main - #12328
Merged
jonathanpeppers merged 1 commit intoAug 10, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates localization outputs for Xamarin.Android.Build.Tasks by adding new localized resource entries for XA1042, XA1043, and XA1048.
Changes:
- Added Japanese localized strings for XA1042/XA1043 and XA1048.
- Added Italian localized strings for XA1042/XA1043 and XA1048.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Localize/loc/ja/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new Japanese .lcl entries for XA1042/XA1043/XA1048. |
| Localize/loc/it/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new Italian .lcl entries for XA1042/XA1043/XA1048. |
Suppressed comments (2)
Localize/loc/ja/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl:961
- Same issue here:
*.lclfiles inLocalize/loc/*are auto-generated and should not be modified directly. Please revert this block and regenerate localization from the English.resxsource.
<Item ItemId=";XA1048" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['{0}' does not contain an <instrumentation> element. Add an Android.App.Instrumentation subclass to the application, or set the $(AndroidInstrumentation) MSBuild property to the name of one.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA['{0}' には <instrumentation> 要素が含まれていません。アプリケーションに Android.App.Instrumentation のサブクラスを追加するか、$(AndroidInstrumentation) MSBuild プロパティをその名前に設定します。]]></Val>
Localize/loc/it/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl:961
- Same issue here: this change edits an auto-generated
*.lcllocalization file. Please revert this block and regenerate the localized outputs from the EnglishResources.resx.
<Item ItemId=";XA1048" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['{0}' does not contain an <instrumentation> element. Add an Android.App.Instrumentation subclass to the application, or set the $(AndroidInstrumentation) MSBuild property to the name of one.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA['{0}' non contiene un elemento <instrumentation>. Aggiungere una sottoclasse di Android.App.Instrumentation all'applicazione oppure impostare la proprietà MSBuild $(AndroidInstrumentation) sul nome di una sottoclasse.]]></Val>
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+900
to
+917
| <Item ItemId=";XA1042" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true"> | ||
| <Str Cat="Text"> | ||
| <Val><![CDATA[The <instrumentation> element in '{0}' is missing the android:name attribute.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA['{0}' の <instrumentation>要素に android:name 属性がありません。]]></Val> | ||
| </Tgt> | ||
| </Str> | ||
| <Disp Icon="Str" /> | ||
| </Item> | ||
| <Item ItemId=";XA1043" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true"> | ||
| <Str Cat="Text"> | ||
| <Val><![CDATA[Could not determine what to launch: '{0}' does not contain a launchable <activity> or an <instrumentation> element. Set the $(AndroidLaunchActivity) or $(AndroidInstrumentation) MSBuild property to specify one.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[起動対象を判断できませんでした: '{0}' には起動可能な <activity>または <instrumentation> 要素が含まれていません。$(AndroidLaunchActivity) または $(AndroidInstrumentation) MSBuild プロパティを設定して、起動対象を指定します。]]></Val> | ||
| </Tgt> | ||
| </Str> | ||
| <Disp Icon="Str" /> | ||
| </Item> |
Comment on lines
+900
to
+917
| <Item ItemId=";XA1042" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true"> | ||
| <Str Cat="Text"> | ||
| <Val><![CDATA[The <instrumentation> element in '{0}' is missing the android:name attribute.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[L'elemento <instrumentation> in '{0}' non contiene l'attributo android:name.]]></Val> | ||
| </Tgt> | ||
| </Str> | ||
| <Disp Icon="Str" /> | ||
| </Item> | ||
| <Item ItemId=";XA1043" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true"> | ||
| <Str Cat="Text"> | ||
| <Val><![CDATA[Could not determine what to launch: '{0}' does not contain a launchable <activity> or an <instrumentation> element. Set the $(AndroidLaunchActivity) or $(AndroidInstrumentation) MSBuild property to specify one.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Non è stato possibile determinare cosa avviare: '{0}' non contiene un elemento activity avviabile <activity> o un elemento instrumentation <instrumentation>. Impostare la proprietà MSBuild $(AndroidLaunchActivity) o $(AndroidInstrumentation) per specificarne una.]]></Val> | ||
| </Tgt> | ||
| </Str> | ||
| <Disp Icon="Str" /> | ||
| </Item> |
jonathanpeppers
approved these changes
Aug 10, 2026
jonathanpeppers
deleted the
juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260809103222429
branch
August 10, 2026 12:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260809103222429 to main with localized lcls